Fix: get rid of "can_reset" and "can_mode". #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both aren't actually very useful, i.e. can_mode is only called by can_reset. And can_reset is only called when pushing frames to the TX FIFO fails. In this case its adequately pushed back to the linux firmware driver who then may - or may not - trigger a complete reinitialsation. At any rate, the device firmware driver should be as dumb as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both aren't actually very useful, i.e. can_mode is only called by can_reset. And can_reset is only called when pushing frames to the TX FIFO fails. In this case its adequately pushed back to the linux firmware driver who then may - or may not - trigger a complete reinitialsation. At any rate, the device firmware driver should be as dumb as possible.